Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AddressSanitizer for the tests #4262

Merged
merged 1 commit into from Apr 4, 2019

Conversation

AntonioBL
Copy link
Contributor

No description provided.

@AntonioBL
Copy link
Contributor Author

Of course the tests will fail because there are open memory address bugs in current code.

@AntonioBL
Copy link
Contributor Author

I enabled only "make installdebug" since it is already calling "make debug". By not calling "make debug" twice we get ~5 min of compilation time.

@AntonioBL
Copy link
Contributor Author

I updated also PR #4001

@dmitrio95
Copy link
Contributor

As #4278 got merged, maybe this PR can also be applied?
@anatoly-os could you please restart the Travis build?

@AntonioBL
Copy link
Contributor Author

It now reports a memory access error for mtest/libmscore/clef_courtesy/tst_clef_courtesy.cpp at line 141 [inside clef_courtesy02()]. I cannot obtain the same report (i.e. everything is fine) when performing the actions of the test via MuseScore GUI, so it could be a problem of dropdata or clef initialization inside the test.

@AntonioBL
Copy link
Contributor Author

And indeed, here:


there is a typo: dropData.element = clef; should read instead dropData.dropElement = clef;

@Jojo-Schmitz
Copy link
Contributor

I'd add the fix from #4334 here (too), just to prove that it plugs a memory hole?

@AntonioBL
Copy link
Contributor Author

Ok. If everything went ok, I should have rebased this PR onto #4334
This should not screw the commit history.

@Jojo-Schmitz
Copy link
Contributor

You may want to join us on Telegram

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants