fix #279023: "Save online" doesn't work #4299
Conversation
|
of course the build on AppVeyor fails due to the missing DLLs: |
| @@ -870,8 +871,10 @@ else (MINGW) | |||
| find_library( dll_vorbis NAMES "libvorbis" PATHS ${DEPENDENCIES_DIR} NO_DEFAULT_PATH) | |||
| find_library( dll_vorbisfile NAMES "libvorbisfile" PATHS ${DEPENDENCIES_DIR} NO_DEFAULT_PATH) | |||
| find_library( dll_portaudio NAMES "portaudio" PATHS ${DEPENDENCIES_DIR} NO_DEFAULT_PATH) | |||
| find_library( dll_ssl1 NAMES "libeay32" PATHS ${DEPENDENCIES_DIR} NO_DEFAULT_PATH) | |||
| find_library( dll_ssl2 NAMES "ssleay32" PATHS ${DEPENDENCIES_DIR} NO_DEFAULT_PATH) | |||
There was a problem hiding this comment.
Considering the system library clause of the GPL does not apply if “that component itself accompanies the executable”, I think the MuseScore licence might need to be amended by the OpenSSL exception now. This will need to be done for all code linked into MuseScore that is under GPL (not LGPL or more liberal), including stuff from Fons Adriaensen, Peter Hanappe, Paul Davis, John Pirie (at least), unless they signed the CLA (in which case Werner can decide to go on adding it), and the thirdparty libraries beatroot and ofqf.
This is not likely to work out.
On the other hand, OpenSSL/LibreSSL are so fundamental it’s probably okay to consider them system libraries by now. This is also not a problem for Debian, since apparently it uses libgcrypt there instead, so I won’t follow up on this, unless someone else thinks it important.
There was a problem hiding this comment.
These libs come as part of MinGW for QtCreator and were included in all former MinGW builds, I just grabbed them from there, and so I don't see how including them in an MSVC build changes anything on the license front...
Requires those 2 libs to get added to dependencies.zip (twice)