fix #278865, fix #279521: reuse system elements layout code in linear mode #4332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, see https://musescore.org/en/node/278153#comment-874239 - the tempo / volta problem is not just continuous view. Apparently it is an issue any time the tempo text and volta are on the same system. So maybe there is hope that this approach can solve that problem as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address a number of issues with continuous view layout by reusing the code for layout of elements belonging to the whole system in page mode. This should help to reduce number of issues that originate from desynchronizing of code for page layout and linear layout. Still this does not resolve all the issues with continuous view, for example, tempo issues with voltas are still remaining.
Still at least these two issues seem to be resolved by this PR:
https://musescore.org/en/node/279521
https://musescore.org/en/node/278865
There may be some concerns regarding performance of this solution but my tests with release builds did not show any noticeable difference. Though optimization issues regarding linear layout still should be addressed at some point later.
P.S. Yes, the branch name slightly mismatch the actual result.