fix #280050: allow cross-measure beams #4472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just eyeballing the code, I like the approach, and it feels like this would be a good basis for eventually supporting them cross-system as well: just change "breakCrossMeasureBeams" to "fixCrossMeasureBeams" :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to return support for cross-measure beams in MuseScore (see this issue). I tried to change as little as possible in layout of beams in all other cases, probably the only change that can potentially change something for them is this one. However there are some difficulties with cross-measure beams as a large part of beams layout takes place on measure layout stage, when no information about systems is reliably available. For that reason I added the same initial layout of cross-measure beams to measure layout stage and break these beams if the corresponding measures happen to be situated in different systems. I don't know whether there are some layout bugs possible because of this change but these will probably concern only some beats involved in cross-measure beams.