[MU4] fix #279780 Better selection of orchestra instruments #4474

Laurelin · 2018-12-22T21:37:09Z

Replaced Baritone Oboe with Bass Oboe - needs to be differentiated via translation. Bass Oboe is English, Spanish, Italian. Baritone is German, French.

Deleted Contrabass Cl, tuba keys, as they are never used in orchestra music. Added many keys of trumpet and horn, C clarinet, a cornet, Cimbasso, Ophelcide, oboe d'amor, bass oboe, tenor trombone, some unpitched percussion to orchestra genre group

Replaced Baritone Oboe with Bass Oboe - needs to be differentiated via translation. Bass Oboe is English, Spanish, Italian. Baritone is German, French. Deleted Contrabass Cl, tuba keys, as they are never used in orchestra music. Added many keys of trumpet and horn, C clarinet, a cornet, Cimbasso, Ophelcide, oboe d'amor, bass oboe, tenor trombone, some unpitched percussion to orchestra genre group

Jojo-Schmitz · 2018-12-23T09:00:38Z

Continued from #4367

anatoly-os · 2018-12-24T07:19:22Z

share/instruments/instruments.xml

@@ -1001,6 +1001,7 @@
                  <Channel>
                        <program value="68"/>
                  </Channel>
+				  <genre>orchestra</genre>


Something is wrong with mixing whitespaces/tabs. We prefer whitespaces everywhere.

Tabs are whitespace ;-). We prefer spaces (which are also whitespace)

anatoly-os · 2018-12-24T07:19:38Z

share/instruments/instruments.xml

                  <barlineSpan>1</barlineSpan>
                  <aPitchRange>47-76</aPitchRange>
                  <pPitchRange>47-78</pPitchRange>
+				  <transposeDiatonic>-7</transposeDiatonic>


Whitespaces/tabs

anatoly-os · 2018-12-24T07:19:43Z

share/instruments/instruments.xml

                  <Channel>
                        <program value="68"/>
                  </Channel>
+				  <genre>orchestra</genre>


Whitespaces/tabs

anatoly-os · 2018-12-24T07:19:47Z

share/instruments/instruments.xml

@@ -1671,6 +1676,7 @@
                  <Channel>
                        <program value="71"/>
                  </Channel>
+				  <genre>orchestra</genre>


Whitespaces/tabs

anatoly-os · 2019-03-01T16:08:22Z

@Laurelin hi! Are you around to address the comments from the review? Let me know whether you have time, otherwise I'll manually apply the changes to master.

* Fix #289672: Reset '$STRING' value strings reference non-existent $STRING * Fix #289957: wrong string in Advanced palette results in it not getting translated (ommission from musescore#5016) * Fix #272546: Baritone Oboe should be named Bass Oboe in English (see also musescore#4474), "Hautbois Baryton" in French, "Bariton Oboe" in German, "Oboe Bajo" in Spanish. Plus: * Add (back) units for sp and pt * Clarify transposition settings in staff properties dialog * Fix a reset button's accessibilty info to match the label * Quote buttons/keys in tours * Barré to Barre * Fix capitalization (see also musescore#5102) * Don't translate debugger (which are not visible in RELEASE mode anyhow)

* Fix #289672: Reset '$STRING' value strings reference non-existent $STRING * Fix #289957: wrong string in Advanced palette results in it not getting translated (ommission from musescore#5016) * Fix #272546: Baritone Oboe should be named Bass Oboe in English (see also musescore#4474), "Hautbois Baryton" in French, "Bariton Oboe" in German, "Oboe Bajo" in Spanish. Plus: * Add (back) units for sp and pt * Clarify transposition settings in staff properties dialog * Fix a reset button's accessibilty info to match the label * Quote buttons/keys in tours * Barré to Barre * Fix capitalization (see also musescore#5102) * Don't translate debugger (which are not visible in RELEASE mode anyhow) * Sfozato to Accent in shortcuts (see https://musescore.org/en/node/290297)

* Fix #289672: Reset '$STRING' value strings reference non-existent $STRING * Fix #289957: wrong string in Advanced palette results in it not getting translated (ommission from musescore#5016) * Fix #272546: Baritone Oboe should be named Bass Oboe in English (see also musescore#4474), "Hautbois Baryton" in French, "Bariton Oboe" in German, "Oboe Bajo" in Spanish. Plus: * Add (back) units for sp and pt * Clarify transposition settings in staff properties dialog * Fix a reset button's accessibilty info to match the label * Quote buttons/keys in tours * Barré to Barre * Fix capitalization (see also musescore#5102) * Don't translate debugger (which are not visible in RELEASE mode anyhow) * Sforzato to Accent in shortcuts (see https://musescore.org/en/node/290297)

* Fix #289672: Reset '$STRING' value strings reference non-existent $STRING * Fix #272546: Baritone Oboe should be named Bass Oboe in English (see also musescore#4474), "Hautbois Baryton" in French, "Bariton Oboe" in German, "Oboe Bajo" in Spanish. Plus: * Add (back) units for sp and pt * Clarify transposition settings in staff properties dialog * Fix a reset button's accessibilty info to match the label * Quote buttons/keys in tours * Barré to Barre * Fix capitalization (see also musescore#5102) * Don't translate debugger (which are not visible in RELEASE mode anyhow) * Sforzato to Accent in shortcuts (see https://musescore.org/en/node/290297)

* Fix #289672: Reset '$STRING' value strings reference non-existent $STRING * Fix #272546: Baritone Oboe should be named Bass Oboe in English (see also musescore#4474), "Hautbois Baryton" in French, "Bariton Oboe" in German, "Oboe Bajo" in Spanish. Plus: * Add (back) units for sp and pt * Clarify transposition settings in staff properties dialog * Fix a reset button's accessibilty info to match the label * Quote buttons/keys in tours * Barré to Barre * Fix capitalization (see also musescore#5102) * Sforzato to Accent in shortcuts (see https://musescore.org/en/node/290297)

* Fix #289672: Reset '$STRING' value strings reference non-existent $STRING * Fix #289957: wrong string in Advanced palette results in it not getting translated (ommission from musescore#5016) * Fix #272546: Baritone Oboe should be named Bass Oboe in English (see also musescore#4474), "Hautbois Baryton" in French, "Bariton Oboe" in German, "Oboe Bajo" in Spanish. Plus: * Add (back) units for sp and pt * Clarify transposition settings in staff properties dialog * Fix a reset button's accessibilty info to match the label * Quote buttons/keys in tours * Barré to Barre * Fix capitalization (see also musescore#5102) * Don't translate debugger (which are not visible in RELEASE mode anyhow) * Sforzato to Accent in shortcuts (see https://musescore.org/en/node/290297) * Some whitespace and punctuation fixes * Fixing some error messages

* Fix #289672: Reset '$STRING' value strings reference non-existent $STRING * Fix #289957: wrong string in Advanced palette results in it not getting translated (ommission from musescore#5016) * Fix #272546: Baritone Oboe should be named Bass Oboe in English (see also musescore#4474), "Hautbois Baryton" in French, "Bariton Oboe" in German, "Oboe Bajo" in Spanish. Plus: * Add (back) units for sp and pt * Clarify transposition settings in staff properties dialog * Fix a reset button's accessibilty info to match the label * Quote buttons/keys in tours * Barré to Barre * Fix capitalization (see also musescore#5102) * Don't translate debugger (which are not visible in RELEASE mode anyhow) * Sforzato to Accent in shortcuts (see https://musescore.org/en/node/290297) * Some whitespace and punctuation fixes * Fixing some error messages * Removing a redundant word

* Fix #289672: Reset '$STRING' value strings reference non-existent $STRING * Fix #289957: wrong string in Advanced palette results in it not getting translated (ommission from musescore#5016) * Fix #272546: Baritone Oboe should be named Bass Oboe in English (see also musescore#4474), "Hautbois Baryton" in French, "Bariton Oboe" in German, "Oboe Bajo" in Spanish. Plus: * Add (back) units for sp and pt * Clarify transposition settings in staff properties dialog * Fix a reset button's accessibilty info to match the label * Quote buttons/keys in tours * Barré to Barre * Fix capitalization (see also musescore#5102) * Don't translate debugger (which are not visible in RELEASE mode anyhow) * Sforzato to Accent in shortcuts (see https://musescore.org/en/node/290297) * Some whitespace and punctuation fixes * Fixing some error messages * Removing a redundant word * Disambiguations for various occurences of "None" which may require different translatations.

* Fix #289672: Reset '$STRING' value strings reference non-existent $STRING * Fix #289957: wrong string in Advanced palette results in it not getting translated (ommission from musescore#5016) * Fix #272546: Baritone Oboe should be named Bass Oboe in English (see also musescore#4474), "Hautbois Baryton" in French, "Bariton Oboe" in German, "Oboe Bajo" in Spanish. Plus: * Add (back) units for sp and pt * Clarify transposition settings in staff properties dialog * Fix a reset button's accessibilty info to match the label * Quote buttons/keys in tours * Barré to Barre * Fix capitalization (see also musescore#5102) * Don't translate debugger (which are not visible in RELEASE mode * Sforzato to Accent in shortcuts (see https://musescore.org/en/node/290297) * Some whitespace and punctuation fixes * Fixing some error messages * Removing a redundant word * Disambiguations for various occurences of "None" which may require different translatations. * Simlify some strings for translatores with URLs

* Fix #289672: Reset '$STRING' value strings reference non-existent $STRING * Fix #289957: wrong string in Advanced palette results in it not getting translated (ommission from musescore#5016) * Fix #272546: Baritone Oboe should be named Bass Oboe in English (see also musescore#4474), "Hautbois Baryton" in French, "Bariton Oboe" in German, "Oboe Bajo" in Spanish. Plus: * Add (back) units for sp and pt * Clarify transposition settings in staff properties dialog * Fix a reset button's accessibilty info to match the label * Quote buttons/keys in tours * Barré to Barre * Fix capitalization (see also musescore#5102) * Don't translate debugger (which is not visible in RELEASE mode) * Sforzato to Accent in shortcuts (see https://musescore.org/en/node/290297) * Some whitespace and punctuation fixes * Fixing some error messages * Removing a redundant word * Disambiguations for various occurences of "None" which may require different translatations. * Simplify some strings with URLs for translators * Don't translate scroipt recorder (which is not visible in RELEASE mode)

Jojo-Schmitz · 2019-07-12T14:15:00Z

The Bariton/Bass Oboe issue is now resolved. Not its transpositioning or genre though.

* Fix #289672: Reset '$STRING' value strings reference non-existent $STRING * Fix #289957: wrong string in Advanced palette results in it not getting translated (ommission from musescore#5016) * Fix #272546: Baritone Oboe should be named Bass Oboe in English (see also musescore#4474), "Hautbois Baryton" in French, "Bariton Oboe" in German, "Oboe Bajo" in Spanish. Plus: * Add (back) units for sp and pt * Clarify transposition settings in staff properties dialog * Fix a reset button's accessibilty info to match the label * Quote buttons/keys in tours * Barré to Barre * Fix capitalization (see also musescore#5102) * Don't translate debugger (which is not visible in RELEASE mode) * Sforzato to Accent in shortcuts (see https://musescore.org/en/node/290297) * Some whitespace and punctuation fixes * Fixing some error messages * Removing a redundant word * Disambiguations for various occurences of "None" which may require different translatations. * Simplify some strings with URLs for translators * Don't translate scroipt recorder (which is not visible in RELEASE mode)

dmitrio95 · 2020-03-12T07:51:40Z

Probably needs a rebase

Jojo-Schmitz · 2020-03-12T08:22:53Z

There's nothing left for this PR to do but to add/remove some genre lines, the rest has been done quite a while ago already

dmitrio95 · 2020-03-12T08:24:41Z

So does this part need to be redone, or perhaps in a new PR?

Jojo-Schmitz · 2020-03-12T08:28:43Z

Well, rebase should fix this, I think. We'd see once that is done ;-)

vpereverzev · 2021-05-05T09:34:00Z

Archived due to inactivity for a long time

Laurelin changed the title ~~Better selection of orchestra instruments~~ fix #279780 Better selection of orchestra instruments Dec 23, 2018

Jojo-Schmitz mentioned this pull request Dec 23, 2018

add instruments to orchestra group #4367

Closed

anatoly-os reviewed Dec 24, 2018

View reviewed changes

anatoly-os added the review label Dec 24, 2018

anatoly-os added the work in progress not finished work or not addressed review label Mar 1, 2019

Jojo-Schmitz mentioned this pull request Jun 4, 2019

fix #289672, fix #272546 and more: fix some strings #5063

Merged

igorkorsukov changed the title ~~fix #279780 Better selection of orchestra instruments~~ [MU4] fix #279780 Better selection of orchestra instruments Feb 5, 2021

vpereverzev removed the review label Mar 4, 2021

vpereverzev closed this May 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MU4] fix #279780 Better selection of orchestra instruments #4474

[MU4] fix #279780 Better selection of orchestra instruments #4474

Laurelin commented Dec 22, 2018

Jojo-Schmitz commented Dec 23, 2018 •

edited

Loading

anatoly-os Dec 24, 2018

Jojo-Schmitz Dec 24, 2018

anatoly-os Dec 24, 2018

anatoly-os Dec 24, 2018

anatoly-os Dec 24, 2018

anatoly-os commented Mar 1, 2019

Jojo-Schmitz commented Jul 12, 2019 •

edited

Loading

dmitrio95 commented Mar 12, 2020

Jojo-Schmitz commented Mar 12, 2020

dmitrio95 commented Mar 12, 2020

Jojo-Schmitz commented Mar 12, 2020

vpereverzev commented May 5, 2021

[MU4] fix #279780 Better selection of orchestra instruments #4474

[MU4] fix #279780 Better selection of orchestra instruments #4474

Conversation

Laurelin commented Dec 22, 2018

Jojo-Schmitz commented Dec 23, 2018 • edited Loading

anatoly-os Dec 24, 2018

Choose a reason for hiding this comment

Jojo-Schmitz Dec 24, 2018

Choose a reason for hiding this comment

anatoly-os Dec 24, 2018

Choose a reason for hiding this comment

anatoly-os Dec 24, 2018

Choose a reason for hiding this comment

anatoly-os Dec 24, 2018

Choose a reason for hiding this comment

anatoly-os commented Mar 1, 2019

Jojo-Schmitz commented Jul 12, 2019 • edited Loading

dmitrio95 commented Mar 12, 2020

Jojo-Schmitz commented Mar 12, 2020

dmitrio95 commented Mar 12, 2020

Jojo-Schmitz commented Mar 12, 2020

vpereverzev commented May 5, 2021

Jojo-Schmitz commented Dec 23, 2018 •

edited

Loading

Jojo-Schmitz commented Jul 12, 2019 •

edited

Loading