fix #280651: unbreak building without QtWebEngine #4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis build failure is unrelated (it waits for an SSH key password). Credits for the patch go to dlc.usa who brought me on the right track. |
mirabilos
force-pushed
the
fix-build-without-webengine
branch
from
829df4e
to
26e262c
Compare
|
Rebased on git master as of today (3.0.1 release equivalent), please apply now. |
Shuffle a few things around so we can use the simplified definition of USE_WEBENGINE everywhere, instead of duplicating the MinGW check.
mirabilos
force-pushed
the
fix-build-without-webengine
branch
from
26e262c
to
f4854c1
Compare
anatoly-os
added a commit
that referenced
this pull request
Feb 8, 2019
fix #280651: unbreak building without QtWebEngine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shuffle a few things around so we can use the simplified definition of
USE_WEBENGINEeverywhere, instead of duplicating the MinGW check.