Use Qt 5.12.1 on AppVeyor and fix #281539 32-bit build for Windows #4583
Conversation
|
I downloaded the AppVeyor artefact and it seems to run just fine. |
shoogle
changed the title
|
Now it is working with Qt 5.12 and MSVC for both 32 bit and 64 bit. Note that when this is merged you need to:
@lasconic, @anatoly-os, I'll leave you to decide on the naming scheme. |
|
see https://musescore.org/en/node/281675 for the naming issue |
|
You should be able to get Qt 5.12.0 for both archs at: |
shoogle
force-pushed
the
appveyor-qt
branch
3 times, most recently
from
bb62760
to
ae78b62
Compare
|
I have updated the URLs and now the package names include the architecture. See AppVeyor build logs and their respective artifacts:
I haven't done anything with the sparkle appcasts as I think that is best left to you guys. |
|
@Jojo-Schmitz, that comment refers to Windows Vista, which is EOL. Nevertheless, I have created a 32 bit build against Qt 5.9 which they can try here: https://ci.appveyor.com/api/buildjobs/rgiqdfd2gds9j2v8/artifacts/MuseScoreNightly-2019-01-26-2134-appveyor-qt-2eed34e-x86.7z |
|
Yes, I noticed that too, but too late, sorry. |
|
I reverted it back to using Qt 5.12 for both 32 bit and 64 bit, but the 32 bit build against Qt 5.9 still exists here if anyone wants to try it. |
shoogle
force-pushed
the
appveyor-qt
branch
2 times, most recently
from
e8c3e12
to
705b273
Compare
|
@anatoly-os, this is ready to merge, unless you have decided you would prefer to wait for AppVeyor to upgrade their Qt? |
|
Is is on Qt 5.12.1? If not, should I pack those for you? |
|
It's still on Qt 5.12, but let's see whether @anatoly-os wants to use it before you pack 5.12.1, and whether the 32 bit build is wanted. |
|
As per appveyor/ci#2760 AppVeyor now supports Qt 5.12.1 builds, also see https://www.appveyor.com/docs/windows-images-software/#qt But only for MinGW and for msvc_2015 64bit Windows (so this here seems still needed) |
|
Since AppVeyor doesn't support 32-bit Qt 5.12 libs, I would consider using this PR when preparing Release. Also, afaics the changes don't increase build time significantly because of downloading qt zip, am I right? |
|
So should I prepare Qt 5.12.1 bundles for 32bit and 64bit? |
|
@anatoly-os, Qt is cached so the download is more or less instantaneous after the first build. Even in the first build it only takes about 5 seconds to download because AppVeyor's internet is fast. Note this from AppVeyor docs:
The first thing this PR does is download Qt (either 32 or 64 bit) and put it in a directory called @Jojo-Schmitz, yes please! |
shoogle
force-pushed
the
appveyor-qt
branch
3 times, most recently
from
6284b6d
to
c40ffe8
Compare
|
@anatoly-os @lasconic, I updated to Qt 5.12.1 thanks to @Jojo-Schmitz. The new Qt packages for 32 bit and 64 bit need to be put on the MuseScore server before this is merged. The build is failing currently for reasons that seem unrelated to this PR. |
|
Seeems this PR is no longer needed, Finally AppVeyor now does spupport msvc2017 32-bit: C:\Qt\5.12.1\msvc2017 and msvc2017 64-bit: C:\Qt\5.12.1\msvc2017_64 |
|
@shoogle could you please adapt the changes in this PR to work with both 32-bit and 64-bit configurations of AppVeyor (https://www.appveyor.com/docs/windows-images-software/#qt)? I mean remove cache for |
|
@anatoly-os, done! |
shoogle
changed the title
| @@ -13,6 +13,7 @@ branches: | |||
| # build cache to preserve files/folders between builds | |||
| cache: | |||
| - dependencies.7z | |||
| # - qt-5.12.1-msvc.7z # if not using AppVeyor's built-in Qt in before_build.bat | |||
| - C:\Qt\Tools\mingw530_32\lib | |||
| - C:\Qt\Tools\mingw530_32\i686-w64-mingw32 | |||
There was a problem hiding this comment.
I don't think these 2 are needed?
There was a problem hiding this comment.
Probably not, but they are not related to this PR and I don't have time to investigate other things right now.
- fix #281539 - 32-bit build for Windows - fix #281675 - add architecture to MSI name - Option to download Qt rather than using AppVeyor's Qt (disabled)
Use Qt 5.12.1 on AppVeyor and fix #281539 32-bit build for Windows
It errored with this message when I tried to build it on my fork:
Not sure if that is my fault.
Build log is here: https://ci.appveyor.com/project/shoogle/musescore/builds/21611397
EDIT: The problem with that
7z's-ooption to set the output directory for files to be extracted to must be used like-o<dir>but I was using it like-o <dir>(i.e. the space is not allowed).