fix #268123: Wrong vertical position of breath mark #4598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The position is now wrong (above staff) for "Bravura", "Gonville" and "MuseJazz". All this fonts can be selected in Style > Score > Musical symbols font If it is just MScore that differ, shouldnt the condition be != "MScore" rather the == "Emmentaler"? |
|
The position is correct for all fonts now. It is supposed to be above the staff for all fonts except Emmentaler. |
|
It is supposed to be above? Well, then it is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://musescore.org/en/node/268123.
The symbol for the breath mark in Emmentaler has a unique appearance, and it is intended to be positioned such that it intersects the top staff line. Other fonts have a symbol that more closely resembles the comma in the palette, and this symbol is intended to be positioned above the staff.
Commit f09f554 was meant to fix the issue linked above, but it repositioned all of the non-caesura breath marks for all of the fonts, rather than just the one breath mark in the MScore font.
This PR also fixes the problem of the symbols not being centered vertically in the palette.
I thought about adjusting the symbol's position in the MScore font itself, but we are already repositioning all of the breath marks anyway during layout. After giving the matter much thought, I have decided that the solution presented in this PR makes more sense.