Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #15373 #460

Closed
Closed

Conversation

lvinken
Copy link
Contributor

@lvinken lvinken commented Sep 2, 2013

Force transposed pitch on MusicXML export by calling score()->cmdConcertPitchChanged() before and after export. Works OK as far as I can tell, please review. I am not completely sure there is no unforeseen interaction with the undo system, as I am not familiar with that.

@lasconic
Copy link
Contributor

I would like the opinion of Werner about this change. I'm not a big fan because it links even more the import/export of MusicXML to mscore while it feels that it should be less linked to it and "closer" to libmscore. That could mean that the concert pitch state should be a Score property... Any opinion?

I believe undo should be ok. But any comment in this area is welcome too.

@lvinken
Copy link
Contributor Author

lvinken commented Sep 19, 2013

I will have to investigate the alternatives. The current solution simply is the easiest one I could come up with. I do understand your concern.

Note that, IMHO, all importers / exporters should only depend on libmscore and not on mscore at all, as all they do is a data transformation between internal and external formats. The only possible exception being error reporting.

@Jojo-Schmitz
Copy link
Contributor

I think that (meanwhile?) concert pitch is a score property. At least if I change the setting in the general style settings, the score gets marked dirty?

@lasconic
Copy link
Contributor

Manually merged in 09d7822

@lasconic lasconic closed this Jun 17, 2014
@lvinken lvinken deleted the 15373-musicxml-concert-pitch branch November 30, 2014 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants