Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #282730: "Untitled"/"My First Score" does not respect locale page size #4620

Merged
merged 2 commits into from
Mar 4, 2019

Conversation

Jojo-Schmitz
Copy link
Contributor

No description provided.

@shoogle
Copy link
Contributor

shoogle commented Jan 26, 2019

Couldn't this be MSCX? I don't think we show the thumbnail anywhere.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Jan 26, 2019

Good idea, done.
Not sure though whether we'd need to convert preferences for older vesions to adjust to that change, nor how to do that.

@shoogle
Copy link
Contributor

shoogle commented Jan 26, 2019

Ah, good point. That would involve finding the place where preferences are read during startup (I think in mscore/musescore.cpp), and then immediately afterwards saying:

if (preferences.startupFile == "My_First_Score.mscz")
      preferences.startupFile = "My_First_Score.mscx"

I believe that would be enough to ensure the new preference is written when MuseScore is closed too.

@Jojo-Schmitz
Copy link
Contributor Author

I guess this should work

@IsaacWeiss
Copy link
Contributor

While at it, any reason to keep the name "My_First_Score"? It's been a couple of years since that name was hidden in the UI: 3edf804

Also, I found where this issue was originally taken care of: acb0991

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Jan 27, 2019

Keeping the name doesn't harm though.
Those changes from acb0991, esp. the score->setPageFormat(*MScore::defaultStyle()->pageFormat()); are commented out with a TODO currently (and since 9a9dedf), so maybe just changing the template won't fix the issue at all?

@anatoly-os anatoly-os merged commit 660de74 into musescore:master Mar 4, 2019
@Jojo-Schmitz Jojo-Schmitz deleted the my-first-score branch March 5, 2019 06:59
anatoly-os added a commit that referenced this pull request Mar 8, 2019
fix #282730: "Untitled"/"My First Score" does not respect locale page size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants