fix #280950: Text style style changes not applied to existing chord symbols #4650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmcclinch
force-pushed
the
280950-harmony-style-changed
branch
2 times, most recently
from
166a617
to
a02daf3
Compare
mattmcclinch
force-pushed
the
280950-harmony-style-changed
branch
from
a02daf3
to
66a4ad0
Compare
mattmcclinch
force-pushed
the
280950-harmony-style-changed
branch
from
66a4ad0
to
bfd32e6
Compare
|
Gotta love those fixes that work by deleting code! |
anatoly-os
added a commit
that referenced
this pull request
Mar 8, 2019
fix #280950: Text style style changes not applied to existing chord symbols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://musescore.org/en/node/280950.
There is no need for Harmony to override TextBase::styleChanged, since TextBase::styleChanged calls setProperty for all the styled properties, and Harmony::setProperty calls render().
Overriding this function without calling TextBase::styleChanged() was the cause of the problem.