Try to fix Windows build #4676
Merged
Try to fix Windows build #4676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dmitrio95
force-pushed
the
try-fix-windows-build
branch
from
08a287f
to
39d906c
Compare
CMakeLists.txt
Outdated
| set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "/MT /permissive- /std:c++14 /W4 /Zi /O2 /Ob1 /DNDEBUG /DQT_NO_DEBUG") | ||
| set(CMAKE_C_FLAGS_DEBUG "/MT /Zi /Ob0 /Od /RTC1") | ||
| set(CMAKE_C_FLAGS_RELEASE "/MT /O2 /Ob2 /DNDEBUG") | ||
| set(CMAKE_C_FLAGS_RELWITHDEBINFO "/MT /Zi /O2 /Ob1 /DNDEBUG") |
There was a problem hiding this comment.
I guess we'd better also add the /DQT_NO_DEBUG and /DQT_NO_DEBUG_OUTPUT here
There was a problem hiding this comment.
Would they make sense for C source code? It doesn't look like Qt works in C language at all.
There was a problem hiding this comment.
Hmm, OK, maybe. Still, it is just defines, so they won't harm at least
dmitrio95
force-pushed
the
try-fix-windows-build
branch
from
1225093
to
c197b96
Compare
dmitrio95
force-pushed
the
try-fix-windows-build
branch
from
c197b96
to
6ddd12b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix AppVeyor build.