fix #281957 move highlight update to work for cursor changes and on click of elements that aren't notes #4766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failed which is probably correct. You need to fix the code, not tests. But it is better to check the tests as well. PS. See #4726 as a beginning of the changes. |
…lick of other elements that aren't notes
peterhieuvu
force-pushed
the
281957-beamproperties
branch
from
08400a4
to
d57c4d2
Compare
|
Oh oops I'm sorry. I made an adjustment which I think should fix the issue. Thank you! |
anatoly-os
added a commit
that referenced
this pull request
Mar 8, 2019
fix #281957 move highlight update to work for cursor changes and on click of elements that aren't notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally had a bit of a flawed implementation where the palette didn't update when clicking onto a different non-chordrest element and also didn't update when changing the selection using the arrow keys. This modification fixes that by moving the updatePaletteBeamMode() function to Musescore::endCmd() instead. I considered using selectionChanged() instead, but there were a few problems with that. When the user applies a new palette element (changing the beam mode by dragging or double clicking on a cell), the selection doesn't change, but the beam mode does change. For that reason I removed the call from mousePressEventNormal() to endCmd(). Let me know if you see a way this could be further improved!