Skylines construction optimization #4768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3508,6 +3508,9 @@ void Score::layoutSystemElements(System* system, LayoutContext& lc) | |||
| if (!mb->isMeasure()) | |||
| continue; | |||
| Measure* m = toMeasure(mb); | |||
| if (MeasureNumber* mno = m->noText(staffIdx)) | |||
| ss->skyline().add(mno->bbox().translated(m->pos() + mno->pos())); | |||
There was a problem hiding this comment.
FWIW, could be worth also adding a check for mno->autoplace() before adding to the skyline. It's one of the few such things I didn't do in my PR #4730. I figure I'll need to update that anyhow if this gets merged first, though.
| @@ -3535,7 +3538,6 @@ void Score::layoutSystemElements(System* system, LayoutContext& lc) | |||
| } | |||
| for (auto n : c->notes()) | |||
| notes.push_back(n); | |||
| std::list<Fingering*> fingerings; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is intended to optimize skylines construction process in two ways:
As this optimization concerns only score layout it presents very little (≈3%) difference while testing on score conversion to various fileformats (like it was performed here). However more specific benchmark (mtest benchmark) shows a difference on layout operations. Here are the results of running that test on the OpenScore edition of the Mozart's Symphony No.41 ("Jupiter") that was converted to MuseScore 3 fileformat, the benchmark was run for 5 times, and average results are presented here. All results are presented in milliseconds (except the percentage difference). Errors are calculated as standard deviations for the benchmark results set.
The results show that this optimization indeed does not influence score reading (without performing a layout) while making a performance gain of about 7—9% for layout operations.