fix #286530: scaling of dot, lines, and more in parts #4858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://musescore.org/en/node/286530
Two separate issues here with similar effects. For stems, lines, tuplets, and probably some other elements, we simply weren't updating the styled properties of the cloned elements. Many things get updated anyhow during the course of layout, but some things aren't - only on construction of the element or on styleChanged(). So, we just needed a call to styleChanged() upon generating the parts.
For dots, the issue was that after cloning the notes, we then call Note::setScore(), but this function forgot to update the dots. So the dots on the note act like they belong to the master score instead of the part.
Both trivial fixes (one I figured out what was going on, anyhow). For safety, I also added a Style::precomputeValues() call on generating the part, but this isn't technically necessary as long we promise not to change any spatium-dependent style values after Sid::spatium itself.