Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bravura and BravuraText to latest Steinberg version 1.32 #4879

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Apr 7, 2019

Plus the newly added LICENSE.txt and README.md.
As taken from https://github.com/steinbergmedia/bravura/

@anatoly-os
Copy link
Contributor

@Jojo-Schmitz what is the reason to update the font?

@Jojo-Schmitz
Copy link
Contributor Author

Just to stay up-todate and on par with Steinberg/Dorico. Also (as of 2 days) a user request: https://musescore.org/en/node/293790

@ecstrema
Copy link
Contributor

There's been a new commit to Bravura a few days ago...

@Jojo-Schmitz Jojo-Schmitz changed the title Update BravuraText to latest Steinberg version 1.277 Update Bravura and BravuraText to latest Steinberg version 1.32 Dec 17, 2019
@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Dec 17, 2019

Integrated/updated.

@dmitrio95
Copy link
Contributor

@Jojo-Schmitz could you please force-push the changes again to trigger the new vtest jobs (#5748)? I don't seem to be able to restart the job which has never been triggered here.

Plus the newly added LICENSE.txt and README.md
@Jojo-Schmitz
Copy link
Contributor Author

done

@AntonioBL
Copy link
Contributor

Once again, the bot failed to comment.
There are very small and basically unnoticeable differences, see https://github.com/musescore/MuseScore/suites/516148100/artifacts/2824689

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Mar 12, 2020

The strange thing is that it changes some Emmentaler, Gonville and MuseJazz vtests too?!? None of those have changed.

@AntonioBL
Copy link
Contributor

Maybe because of fallback font?

@Jojo-Schmitz
Copy link
Contributor Author

Possible. If so unavoidable and the vtests just need to get adjusted

@AntonioBL
Copy link
Contributor

No need to update the vtests: the Github action automatically compares the PR and its parent base commit. I will expect only an automated message will be posted in the merge commit underlining the fact that vtests have changed.
(At least, I hope the message will be triggered, so that we have a confirmation that, at least for push commit, the bot is doing its work)

@Jojo-Schmitz
Copy link
Contributor Author

Ah, OK, thanks.

@dmitrio95 dmitrio95 merged commit 78db47d into musescore:master Mar 18, 2020
@Jojo-Schmitz Jojo-Schmitz deleted the BravuraText branch March 18, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants