fix #287617: set barline span for added staves #4912
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://musescore.org/en/node/287617
In b6bea0e I added code to make sure added staves inherit modifed barlines (double bars, etc) from the rets of the score. But in the process, this made them also pick up the barline span fior those barlines, which isn't necessarily appropriate. So, here I am making two changes. One, explicitly resetting the span of these barlines to the staff default. But also, I am setting the staff default for these newly added staves based on the span of the staff above. This is a quite nice improvement over 2.3.2 - now if you add a staff in the middle of a spanned woodwind section, for example, the barlines are already spanned on the new staff as well. Works as expected when adding at the end of a spanner section, or at the top of the score - no span in that case.