Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #287617: set barline span for added staves #4912

Merged
merged 2 commits into from
May 20, 2019

Conversation

MarcSabatella
Copy link
Contributor

See https://musescore.org/en/node/287617

In b6bea0e I added code to make sure added staves inherit modifed barlines (double bars, etc) from the rets of the score. But in the process, this made them also pick up the barline span fior those barlines, which isn't necessarily appropriate. So, here I am making two changes. One, explicitly resetting the span of these barlines to the staff default. But also, I am setting the staff default for these newly added staves based on the span of the staff above. This is a quite nice improvement over 2.3.2 - now if you add a staff in the middle of a spanned woodwind section, for example, the barlines are already spanned on the new staff as well. Works as expected when adding at the end of a spanner section, or at the top of the score - no span in that case.

@RobFog
Copy link

RobFog commented Apr 13, 2019

Travis failed?

@MarcSabatella
Copy link
Contributor Author

Thanks for the heads up! splitstaff tests now produce different barline spans. Checking, but it looks like the new behavior is correct so I just need to update the references.

@anatoly-os anatoly-os merged commit 1b349c1 into musescore:master May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants