Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing duration of multiple notes #4932

Merged
merged 1 commit into from May 1, 2019

Conversation

dmitrio95
Copy link
Contributor

Addresses another UX issue mentioned in the Tantacrul's video review. This patch allows changing duration of multiple notes just by applying the same length changing operation for every chord/rest. As suggested by @anatoly-os, the order of applying the operation is determined by the chords/rests position: length changes for the last chord/rest first.

This change should probably be useful as it is but in some cases it yields not ideal results, for example:

  • when lengthening chords so that they overlap with the second measure (only the last chord gets properly lengthened and tied);
  • when lengthening notes so that they start to overlap.

Still these changes are undoable so it should be possible to reverse them, whichever the result is.

There is also no explicit prohibition of applying this operation to range selection in the current version of the patch. It is easy to add it but there is also another alternative. We can just ignore any non-ChordRest elements in the selection and change note length for all of them, and this will still work. This should allow, for example, to range-select the whole segment and change note lengths in it. However this makes it easier to make some mistake if the wrong button is pressed while a range is selected. Does it make sense to allow changing notes duration for range selection or is it better to forbid it at all?

@MarcSabatella
Copy link
Contributor

Nice work! It's a pretty common mistake for people to press a duration key before entering note input mode (and then wonder why they end up getting a quarter note when they enter a note), so I do worry a little about people clicking a measure to select a start point, then clicking a duration in anticipate of pressing "N". But I'm not too worried, it's actually maybe a good clue to them that they aren't doing something right. Could be worth adding a "tour" when this happens, though.

@anatoly-os anatoly-os merged commit 4696164 into musescore:master May 1, 2019
@dmitrio95 dmitrio95 deleted the change-duration-multiple branch June 3, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants