Allow changing duration of multiple notes #4932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses another UX issue mentioned in the Tantacrul's video review. This patch allows changing duration of multiple notes just by applying the same length changing operation for every chord/rest. As suggested by @anatoly-os, the order of applying the operation is determined by the chords/rests position: length changes for the last chord/rest first.
This change should probably be useful as it is but in some cases it yields not ideal results, for example:
Still these changes are undoable so it should be possible to reverse them, whichever the result is.
There is also no explicit prohibition of applying this operation to range selection in the current version of the patch. It is easy to add it but there is also another alternative. We can just ignore any non-ChordRest elements in the selection and change note length for all of them, and this will still work. This should allow, for example, to range-select the whole segment and change note lengths in it. However this makes it easier to make some mistake if the wrong button is pressed while a range is selected. Does it make sense to allow changing notes duration for range selection or is it better to forbid it at all?