fix #285467: unequal system distances #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Special thanks for the comments in the code! |
This was referenced May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://musescore.org/en/node/285467. The issue is, distances between systems can vary within a page, with shorter systems receiving larger gaps than taller ones. This was a deliberate change by @wschweer in b4eef5d to "normalize" system distances. But it seems unpopular, and I don't see anything specific in Gould recommending it. So this PR essentially reverts the portion of the change responsible for the normalization of system distances.
On the other hand, I recognize that this normalization could be desirable sometimes. I have added comments to explain the code for future reference, and also added some parameterization so one can tweak how much of normalization takes place, but then I #ifdef'ed out the relevant portion of the code.
This should return behavior to more like 2.3.2, while leaving open the possibility of bringing the normalization algorithm back in some form, perhaps controlled by a style option or options.