fix #288383: Crash when inserting notes in voice 2 when first rest is deleted #4972
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/288383.
InputState::nextInputPos()
was not returning the appropriate segment when it encountered a gap in voice 2 that was of a different duration than the rest in voice 1. This is because the loop was ending too early due to the fact thatm
was no longer equal tos->measure()
. This could have been a one-line fix, but I took this opportunity to remove the double check forif (s->element(_track))
.