fix #283120: concert pitch button now toggles text also

[peterhieuvu]

The concert pitch button is a little confusing as is. With this change the button will also cycle between "Concert Pitch" and "Transposed" while still keeping the toggle button. This way it's still easy to see if something is Concert Pitch at first glace (using the shading), but for newer users the text is there to make the button more intuitive.

[Jojo-Schmitz]

Maybe better toggle the tooltip text too, I guess. Or extend that tooltip to cover either setting Toggle between 'Transposed' and 'Concert Pitch'. Actually I like that better.

[peterhieuvu]

Maybe better toggle the tooltip text too, I guess. Or extend that tooltip to cover either setting Toggle between 'Transposed' and 'Concert Pitch'

That's a good point, I left it alone at first because I thought I'd just leave the tooltip to show the functionality of the button, but now I realize that can be confusing. I'll just extend the tooltip to cover both settings for now, but I've asked on the issue page about other options to see what might be the best.

[Jojo-Schmitz]

rebase needed

[peterhieuvu]

Hmm wait, I'm not sure if this should be a part of the 3.3.1 milestone, I think we decided that this wasn't really a good change to make.

[anatoly-os]

See last comment written by @peterhieuvu