fix #289293: articulation min distance not written #5027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthistle
reviewed
May 18, 2019
libmscore/fret.cpp
Outdated
| @@ -39,6 +39,7 @@ static const ElementStyle fretStyle { | |||
| { Sid::fretStrings, Pid::FRET_STRINGS }, | |||
| { Sid::fretFrets, Pid::FRET_FRETS }, | |||
| { Sid::fretNut, Pid::FRET_NUT }, | |||
| { Sid::fretMinDistance, Pid::MIN_DISTANCE }, | |||
There was a problem hiding this comment.
This and the line change below are fixed in #5029, so could be removed from here.
There was a problem hiding this comment.
Yes, depending on which gets merged first, but that's for incorporating this!
|
If #5029 is merged first, I will update this. |
MarcSabatella
force-pushed
the
289293-write-mindistance
branch
from
7e3e326
to
edc3849
Compare
|
I pushed an update that splits this into two commits to make it possible to cherry-pick just the articulation one if #5029 is merged. I tried to update the fret diagram change to be consistent with the other PR, but it wasn't really possible as a new property was added and the order of writing properties changed. |
MarcSabatella
force-pushed
the
289293-write-mindistance
branch
from
edc3849
to
1b194ce
Compare
MarcSabatella
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://musescore.org/en/node/289293. Just a matter of making sure we write the properties. And in the case of fret diagrams, I needed to make it a styled property, as it was also not being initialized correctly.