disable autoflip for fingering #5040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autoflip code (automatically change placement when user manually moves an element to opposite side of staff) was only designed to work for elements that are actually placed relative to the staff. Fingerings are placed relative to the note, so the detection of when we have flipped is wrong, so is the adjustment to the offset, resulting in cases where we set placement to below even though you're actually above or vice versa, and a sudden jump in the offset too.
In principle this is fixable, but the right way to do so is to rearchitect things a bit as discussed in the thread #4982. So for now I'm just disabling the autoflip code for elements attached to notes or rests. This also includes lyrics attached to rests, which have the same issue. Most lyrics are attached to chords, not notes, and this still works.