fix #166116: Slurs terminate in wrong spot in voices other than 1 #5049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrio95
reviewed
Nov 18, 2019
| el.front()->setSelected(false); | ||
| // Now make sure that the slur segment is redrawn so that it does not *look* selected |
There was a problem hiding this comment.
Wouldn't just update() call be sufficient to trigger redrawing? It doesn't look like re-layout is necessary here.
There was a problem hiding this comment.
You are right. Calling update() is sufficient. I have just made this change to the PR.
mattmcclinch
force-pushed
the
166116-slur-end
branch
from
39cbae7
to
d173093
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/166116