Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #289765: Continuous view: Key change forces double barline #5076

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

Jojo-Schmitz
Copy link
Contributor

No description provided.

@MarcSabatella
Copy link
Contributor

The meaning of that parameter is to force a few special behaviors for the last measure in the system. One is indeed this: automatically adding the double bar before a courtesy key signature. Another is to suppress the end barline for a measure that is immediately followed (on the same system) by a start repeat. So, calling createEndBarLines with this set to false will mean we skip the barline before a start repeat, which is good since it's what we do in page view too. It's harmless but maybe it's causing the thick portion of the start repeat to be too thick by half a normal barline width?

Anyhow, my sense is this should be harmless, and if it helps the drawing of the start repeat, maybe even somewhat beneficial. But also not really necessary.

@Jojo-Schmitz Jojo-Schmitz reopened this May 27, 2019
@anatoly-os anatoly-os merged commit 5892cad into musescore:master Aug 1, 2019
@Jojo-Schmitz Jojo-Schmitz deleted the continuous branch August 1, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants