Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't merge] fix #289898: dynamic changes do not playback for tremolos #5085

Closed

Conversation

jthistle
Copy link
Contributor

@jthistle jthistle commented May 30, 2019

Resolves: https://musescore.org/en/node/289898

This fix works by always rendering single-note dynamics events, even when an instrument doesn't have single-note dynamics enabled. Then, when collecting a note, a reference to the list of CC velocity events is passed to it. Each note event for that note then searches for the correct velocity from the list if it exists and uses it in playNote.

This leads to two arrays for events:

tempPlayEvents - the SND velocity events that will actually be rendered

tempAllVelEvents - all the SND velocity events, regardless of whether they'll be rendered or not

@jthistle jthistle force-pushed the 289898-tremolo-dynamic-playback branch from e45db9e to 37e7fc2 Compare May 31, 2019 08:15
@jthistle jthistle force-pushed the 289898-tremolo-dynamic-playback branch from 37e7fc2 to 641bf7b Compare May 31, 2019 08:24
@Jojo-Schmitz
Copy link
Contributor

rebase needed

@jthistle jthistle changed the title fix #289898: dynamic changes do not playback for tremolos [Don't merge] fix #289898: dynamic changes do not playback for tremolos Aug 3, 2019
@jthistle
Copy link
Contributor Author

Superseded by #5264

@jthistle jthistle closed this Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants