[Don't merge] fix #289898: dynamic changes do not playback for tremolos #5085
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/289898
This fix works by always rendering single-note dynamics events, even when an instrument doesn't have single-note dynamics enabled. Then, when collecting a note, a reference to the list of CC velocity events is passed to it. Each note event for that note then searches for the correct velocity from the list if it exists and uses it in
playNote
.This leads to two arrays for events:
tempPlayEvents
- the SND velocity events that will actually be renderedtempAllVelEvents
- all the SND velocity events, regardless of whether they'll be rendered or not