[MU4] fix#15513 Enable pedals to take the whole part into consideration when extending #5123
Conversation
| class Element : public ScoreElement { | ||
| ElementScope _scope { ElementScope::STAFF }; |
There was a problem hiding this comment.
Would it make more sense to implement this as a virtual function that returns ElementScope::STAFF in class Element, but can be overridden in class Pedal to return ElementScope::PART?
There was a problem hiding this comment.
It might. I'll have to think a bit. I want this to enable users to set the scope for which the element has effect in the inspector. Hard-coding it in the class definition for each element won't work for that.
My other option was to make the _scope member protected and only implementing accessors where I want to expose the value publicly (as in dynamics, so that the Inspector can set its scope, or haripins and cresc./dim. lines).
| else if (ed.curGrip == Grip::END || ed.curGrip == Grip::MIDDLE) { | ||
| Segment* ns2 = nextSeg1(s2, track2); | ||
| Segment* ns2{ nextSeg1(s2, track2, startTrack, endTrack) }; |
There was a problem hiding this comment.
A space is missing here before the {.
There was a problem hiding this comment.
Yeah, Visual Studio likes to eat those spaces before the opening curly brace in an initializer. Will update together with the code for your other comment when we figured the other one out.
igorkorsukov
changed the title
vpereverzev
added
the
archived
|
Archived for in-activity |
Pedal lines can now extend to notes in another staff of the same part too. To enable that, I added an
enum classnamedElementScopeinelement.h. This enum has basically an identical function to theDynRangeenum indynamic.h, but only adds one more range:VOICE. This lays the groundwork for making the "Range" concept applicable to a broader range of different elements. Those which doesn't need it doesn't need to use it anywhere else than setting it to an appropriate default in its constructor.