fix #287432: Key signature appears in multimeasure rest after being deleted from underlying measure #5134
Conversation
…eleted from underlying measure
| @@ -4011,7 +4011,7 @@ void Measure::removeSystemTrailer() | |||
| changed = true; | |||
| } | |||
| setTrailer(false); | |||
| if (changed) | |||
| if (system() && changed) | |||
There was a problem hiding this comment.
What's the purpose of this extra check? Is it just an optimization because we know we're going to recompute the width later anyhow? My recollection is system() will be null while we are still testing whether the measure fits, I'd have thought we needed to get the width correct here.
There was a problem hiding this comment.
Well, I could have put the check in computeMinWidth() instead. The purpose is to make sure that the null system is not dereferenced in computeMinWidth().
There was a problem hiding this comment.
Usually when this function is called, this already has a valid system. That is not the case if this function is called from createMMRest(). I considered copying most of the code from removeSystemTrailer() and pasting it into createMMRest(), but I opted for this approach.
There was a problem hiding this comment.
Yes, you're right, my mistake in thinking this was normally being called before the measure is added to the system.
BTW, I know I've seen this behavior - leftover trailer at end of score - before. I can't say for sure if this was the exact scenario or not.
Resolves: https://musescore.org/en/node/287432.
This is a follow-up to #4884.
When an existing mmrest is reused upon reenabling multimeasure rests, the old system trailer should be removed. It will be added back if needed. Also, the mmrest should take on the layout break properties of the last underlying measure, whether an existing mmrest was reused or not.