fix #289254: Beam in edit mode always switches to right grab handle #5156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmcclinch
force-pushed
the
289254-change-state
branch
from
bb54e8f
to
497855a
Compare
dmitrio95
reviewed
Nov 18, 2019
| undoChangeProperty(Pid::USER_MODIFIED, true); | ||
| undoChangeProperty(Pid::BEAM_POS, QPointF(y1 / _spatium, y2 / _spatium)); |
There was a problem hiding this comment.
Are there any reasons why we need this order exactly? If so it would be better to leave a comment explaining that in the code.
There was a problem hiding this comment.
Yes, there is a reason. See https://musescore.org/en/node/289254#comment-933890, which is in response to the comment just before it. I have just added a comment in the code explaining why the order is important.
mattmcclinch
force-pushed
the
289254-change-state
branch
from
497855a
to
4c5e745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/289254.