fix #291261: Make volta mouse drops apply only to first staff by default #5182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #291431: Incorrect drop anchor displayed while dragging a Volta
|
I've tested this PR and it seems to work correctly. |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/291261.
Also resolves: https://musescore.org/en/node/291431.
This PR makes use of the
ScoreView::dragMeasureAnchorElement()function that was once used when dragging Voltas from the palette, but is no longer in use. I have updated this function to make it more consistent withScoreView::dragTimeAnchorElement(), and I have modified it to allow the anchor to be on a staff other than the top one if the user is holding down the Control key.I would like to thank @ericfont for the work he did on #5167, which was the basis for this PR.