fix #291992 and fix #291991: “Play Panel” and "Mixer" is untranslated #5217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
translations
branch
from
835abc1
to
89f2f57
Compare
and setting the title of docked plugins to their name in the menu rather than to "Plugin"
Jojo-Schmitz
force-pushed
the
translations
branch
from
89f2f57
to
2030719
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and setting the windowTitle of docked plugins to their name in the menu rather than to "Plugin".
Unrelated to the isues in one way, but related in another: these are only other occurence where the 1st paramenter to
QDockWidget()is an untranslatable string literal. Here no need for a translation, as the Plugin's name is the better alternative anyhow.The other changes just recycle already existing strings and their translations, so this PR works right away, no work for the translator.