Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #292851: Note still played after having been deleted. #5252

Merged
merged 1 commit into from Aug 3, 2019

Conversation

@mattmcclinch
Copy link
Contributor

commented Aug 1, 2019

Resolves: https://musescore.org/en/node/292851.

This fixes the problem by adding a call to Score::setPlaylistDirty() when a note is removed from its chord, and when a chord is removed from its segment.

@dmitrio95

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

This fix leaves a similar issue on undoing the note removal operation. That is, the following works incorrectly:

  1. Remove a note from a chord
  2. Click on some note before that chord, start/stop playback
  3. Click on some note before that chord again
  4. Undo
  5. Play

Maybe similar setPlaylistDirty calls are also needed on adding notes and chords to a score.

@mattmcclinch mattmcclinch force-pushed the mattmcclinch:292851-deleted-note branch from 71f6f1c to cc885c1 Aug 3, 2019

@mattmcclinch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2019

Good point. Somehow I had missed that scenario during testing. I just pushed a change that does what you suggest.

@dmitrio95 dmitrio95 merged commit f7ae2b6 into musescore:master Aug 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.