Fix #292900: Plugin: Expose Element.pos X/Y values to plugins. #5254
Conversation
DLLarson
changed the title
DLLarson
force-pushed
the
expose-element-pos
branch
from
79d7429
to
a88063f
Compare
mscore/plugin/api/elements.h
Outdated
| @@ -88,6 +88,20 @@ class Element : public Ms::PluginAPI::ScoreElement { | |||
| * \since 3.3 | |||
| */ | |||
| Q_PROPERTY(Ms::PluginAPI::Element* parent READ parent) | |||
| /** | |||
| * Computed X-axis layout position from a reference position. | |||
There was a problem hiding this comment.
Could it perhaps be better to say that this is actual position rather than computed to denote that it includes also offset and all other possible modifiers as its part? Or, as another option, perhaps we could explicitly mention the fact that this already includes any offset applied.
There was a problem hiding this comment.
I've updated the api description.
-Dale
Expose Element.pos X/Y values so that plugin's can accurately position things like STAFF_TEXT on the score. One example is to position a tin whistle finger hole pattern directly under a grace note. Another is to place note names properly using MuseScore's shipped notename.qml plugin.
Modify plugin to take advantage of exposure of element.posX/Y which allows for precise positioning of elements like STAFF_TEXT.
DLLarson
force-pushed
the
expose-element-pos
branch
from
a88063f
to
26ab4f5
Compare
| for (var i = 0; i < notes.length; i++) { | ||
| var sep = ","; // change to "\n" if you want them vertically | ||
| var sep = "\n"; // change to "," if you want them horizontally (anybody?) |
There was a problem hiding this comment.
@Jojo-Schmitz, that seems to be your code originally, do you agree with changing this default?
There was a problem hiding this comment.
Please check out my examples at the issue web page to see why I made that switch.
-Dale
There was a problem hiding this comment.
@dmitrio95 I'm fine with that, and it isn't really my code alone anyway
DLLarson
force-pushed
the
expose-element-pos
branch
from
83dde0f
to
26ab4f5
Compare
Expose Element.pos X/Y values so that plugin's can accurately
position things like STAFF_TEXT on the score. One example is
to position a tin whistle finger hole pattern directly under
a grace note. Another is to place note names properly using
MuseScore's shipped notename.qml plugin.