Fix #293837: Plugin: WIP: Add ability to compare sameness of MuseScore QML elements. #5281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DLLarson
force-pushed
the
plugin-object-comparison-fix
branch
from
6f14bc6
to
91f3114
Compare
DLLarson
changed the title
DLLarson
force-pushed
the
plugin-object-comparison-fix
branch
6 times, most recently
from
0c9dc58
to
5898b90
Compare
dmitrio95
reviewed
Aug 29, 2019
libmscore/scoreElement.h
Outdated
| @@ -171,6 +171,9 @@ struct ElementName { | |||
|
|
|||
| class ScoreElement { | |||
| Score* _score; | |||
| #ifdef SCRIPT_INTERFACE | |||
| QObject* _plugInWrapper; | |||
There was a problem hiding this comment.
You can define a default value for this variable just here:
QObject* _plugInWrapper = nullptr;
Then there will be no need in having two different constructors depending on SCRIPT_INTERFACE definition and in initializing this value explicitly in copy constructor.
There was a problem hiding this comment.
Thanks! Much cleaner now.
-Dale
DLLarson
force-pushed
the
plugin-object-comparison-fix
branch
4 times, most recently
from
46cd6fd
to
e3b4355
Compare
DLLarson
force-pushed
the
plugin-object-comparison-fix
branch
2 times, most recently
from
1206db1
to
61a3e78
Compare
|
rebase neeeded |
…e QML elements. A property named 'elementId' has been added to all score elements so that QML scripting can compare two different QML elements to see if they are accessing the same MuseScore object beneath the plugin wrappers. This is needed because there may be more than one wrapper for an object at the scripting layer depending how the script obtained the element object.
This patch ensures that there is only one QML wrapper object for each internal object that is exposed to scripting. This enables simple sameness comparisons between javascript objects.
Change Ms::PluginAPI::ScoreElement based wrapper ownership to be "QQmlEngine::CppOwnership" rather than "QQmlEngine::JavaScriptOwnership" so that wrappers won't be garbage collected before the proxied Ms::ScoreElement is destroyed. Upon destruction of the proxied element, the wrapper ownership will be set to "JavaScriptOwnership" and the wrapper's pointer to the wrapped element is set to nullptr to prevent accessing freed heap memory. NOTE: This commit should be merged into the main commit when found to be an acceptable approach.
This restricts changes of wrapper ownership to CppOwnership for objects returned by the `curScore` scripting property.
DLLarson
force-pushed
the
plugin-object-comparison-fix
branch
from
61a3e78
to
4dd8ad4
Compare
vpereverzev
added
the
archived
|
Automatically archived due to long inactivity. Could be re-opened later once an author will come back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress to test ideas for comparing objects in QML scripts.
Note that there may be several patches using different solutions. When the PR is ready to go it will be reduced down to the final approach.
-Dale