Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #293707: undo doesn't restore deleted frame immediately #5293

Merged

Conversation

@jthistle
Copy link
Contributor

commented Sep 1, 2019

Resolves: https://musescore.org/en/node/275545

This also adds a test for this case.

@jthistle jthistle referenced this pull request Sep 2, 2019
30 of 30 tasks complete
@anatoly-os anatoly-os referenced this pull request Sep 3, 2019
3 of 17 tasks complete

@anatoly-os anatoly-os added this to the MuseScore 3.3 Beta 2 milestone Sep 4, 2019

@anatoly-os

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

@jthistle could you please add the answer to the question "Why do those changes fix that particular issue?" to the commit log?

See Matt's commit logs in e98b0ed and a4a5173 as a good example.

@jthistle

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

Sure, will do when I get home. BTW, nice to see milestones in use :)

fix #293707: undo doesn't restore deleted frame immediately
Why do these changes fix this particular issue?

After adding any other element, we `setLayout` at the element's
location. However, for boxes, there is an early return, and this step is
missed, meaning the box won't appear until a relevant measure is layed out.
This fix adds the missing `setLayout`.

@jthistle jthistle force-pushed the jthistle:293707-undo-no-restore-deleted-frame branch from e7adf9f to 3f40a56 Sep 4, 2019

@jthistle

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

Commit message fixed @anatoly-os

@anatoly-os anatoly-os merged commit 60f463f into musescore:master Sep 4, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.