fix #293707: undo doesn't restore deleted frame immediately #5293
+513
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
17 tasks
|
Sure, will do when I get home. BTW, nice to see milestones in use :) |
Why do these changes fix this particular issue? After adding any other element, we `setLayout` at the element's location. However, for boxes, there is an early return, and this step is missed, meaning the box won't appear until a relevant measure is layed out. This fix adds the missing `setLayout`.
jthistle
force-pushed
the
293707-undo-no-restore-deleted-frame
branch
from
e7adf9f
to
3f40a56
Compare
|
Commit message fixed @anatoly-os |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/275545
This also adds a test for this case.