fix #293981: double ampersand in palette names #5294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatoly-os
reviewed
Sep 2, 2019
mscore/menus.cpp
Outdated
| sp->setGrid(27, 50); | ||
| sp->setDrawGrid(true); | ||
| sp->setName(QT_TRANSLATE_NOOP("Palette", "Arpeggios & Glissandi")); | ||
| sp->setGrid(27, 50); sp->setDrawGrid(true); |
There was a problem hiding this comment.
Brown Bag Warning: you removed line ending in the improper place.
The new workspaces show the double ampersand on some palettes, in the old ones this was needed to prevent them from becoming (duplicate) mnemonics, seems the new workspace/palettes schema doesn't need them anymore.
Jojo-Schmitz
force-pushed
the
double-ampersand
branch
from
906ceaf
to
cfe7039
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new workspaces show the double ampersand on some palettes, in the old ones this was needed to prevent them from becoming (duplicate) mnemonics, seems the new workspace/palettes schema doesn't need them anymore.