fix #294297: Cross-Measure Beam Custom Position Not Restored #5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a beam is created in Measure::readVoice(), it will initially contain only one element. Later, during layout, Score::createBeams() will fill in the remaining elements of the beam. This commit basically reverts 932257f and 08c583f, and implements a slightly different take on a fix for https://musescore.org/en/node/285100 that looks at beamMode of the next ChordRest rather than the elements in a beam that may not yet have been filled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/294297.
When a beam is created in Measure::readVoice(), it will initially contain only one element. Later, during layout, Score::createBeams() will fill in the remaining elements of the beam. This commit basically reverts 932257f and 08c583f, and implements a slightly different take on a fix for https://musescore.org/en/node/285100 that looks at beamMode of the next ChordRest rather than the elements in a beam that may not yet have been filled.