Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4] New XML and MXL File Icons #5386

Closed
wants to merge 2 commits into from
Closed

[MU4] New XML and MXL File Icons #5386

wants to merge 2 commits into from

Conversation

liamrosenfeld
Copy link
Contributor

@liamrosenfeld liamrosenfeld commented Oct 15, 2019

This brings the new XML and MXL designs from #3269 but without the excessive amount of over-engineering for the build system (we got quite carried away).

This could also be an opportunity to provide those file icons on macOS and Windows—I would be more than happy to add it, I would just need to first be pointed in the right direction.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"

@liamrosenfeld
Copy link
Contributor Author

I think I figured out how to add that document icon on macOS (last commit), though I'm still not sure about Windows.

@anatoly-os anatoly-os added this to the MuseScore 3.3.1 milestone Oct 22, 2019
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Oct 28, 2019

For Windows maybe check #5421 (comment), but that probably won't help for the icons here, as MuseScore doesn't register itself for MusicXML files?

@liamrosenfeld
Copy link
Contributor Author

@Jojo-Schmitz, should I create a new instance of:

<RegistryValue Root="$(var.RegistryRoot)" Key="SOFTWARE\Classes\MuseScore.mscx" Value="MuseScore File" Type="string" />
            <ProgId Id="MuseScore.mscx" Description="MuseScore File" Advertise="no" Icon="$(var.ExeId)" IconIndex="1">
                <Extension Id="mscx" Advertise="no">
                    <Verb Id="open" TargetFile="$(var.ExeId)" Command="Open" Argument="&quot;%1&quot;" />
                    <MIME Advertise="no" ContentType="application/x-musescore+xml" Default="no" />
                </Extension>
            </ProgId>

to register itself for MusicXML files?

@Jojo-Schmitz
Copy link
Contributor

I don't think so. Maybe better asking @anatoly-os

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Dec 17, 2019

rebase needed (but hold it until the master build got fixed)

@liamrosenfeld
Copy link
Contributor Author

liamrosenfeld commented Dec 18, 2019

@Jojo-Schmitz, I rebased. 👍

@anatoly-os, do you have any guidance on how I could expand this new icon to the Windows target?

@anatoly-os
Copy link
Contributor

It's up to @Tantacrul to decide whether we want to have better MXL icons. Martin, what do you think?

@anatoly-os anatoly-os removed this from the MuseScore 3.5 milestone Apr 7, 2020
@igorkorsukov igorkorsukov changed the title New XML and MXL File Icons [MU4] New XML and MXL File Icons Feb 5, 2021
@vpereverzev vpereverzev added the archived PRs that have gone stale but could potentially be revived in the future label May 5, 2021
@vpereverzev vpereverzev closed this May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archived PRs that have gone stale but could potentially be revived in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants