New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU4] New XML and MXL File Icons #5386
Conversation
I think I figured out how to add that document icon on macOS (last commit), though I'm still not sure about Windows. |
For Windows maybe check #5421 (comment), but that probably won't help for the icons here, as MuseScore doesn't register itself for MusicXML files? |
@Jojo-Schmitz, should I create a new instance of:
to register itself for MusicXML files? |
I don't think so. Maybe better asking @anatoly-os |
rebase needed (but hold it until the master build got fixed) |
@Jojo-Schmitz, I rebased. 👍 @anatoly-os, do you have any guidance on how I could expand this new icon to the Windows target? |
It's up to @Tantacrul to decide whether we want to have better MXL icons. Martin, what do you think? |
This brings the new XML and MXL designs from #3269 but without the excessive amount of over-engineering for the build system (we got quite carried away).
This could also be an opportunity to provide those file icons on macOS and Windows—I would be more than happy to add it, I would just need to first be pointed in the right direction.