fix #292830: fix copying lyrics to clipboard #5400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was broken after 1a6058f. Score::extractLyrics() depends on Measure::_playbackCount values which are used internally by RepeatList. A quick way to fix the issue with extracting lyrics (implemented in this commit) is to force repeat list to be computed before resetting playbackCount variables inside extractLyrics().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/292830
Was broken after 1a6058f. Score::extractLyrics() depends on Measure::_playbackCount values which are used internally by RepeatList. A quick way to fix the issue with extracting lyrics (implemented in this commit) is to force repeat list to be computed before resetting playbackCount variables inside extractLyrics().