fix #295944: Tuplet dialog does not default to style settings, and creates tuplets with bad property flags #5408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eates tuplets with bad property flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/295944.
This PR implements a feature request and fixes a bug.
The bug is that tuplets created with the tuplet dialog have their property flags for Pid::NUMBER_TYPE and Pid::BRACKET_TYPE set incorrectly, so that when the score is saved, these properties will not be written, even if they differ from the default values.
The feature request is to have the tuplet dialog open up with the current style settings for Sid::tupletNumberType and Sid::tupletBracketType selected by default.