fix #296171: fix triggerLayoutAll() for spanners #5424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixup for 99c7b0d triggerLayout() and triggerLayoutAll() implementations in Element have an optimization that allows to avoid triggering layout for elements not yet added to a score by checking the element's parent. This optimization is not suitable for spanners since they don't have a parent even when added to a score. This commit adds a missing implementation of Spanner::triggerLayoutAll() that takes this into account.
anatoly-os
pushed a commit
that referenced
this pull request
Oct 30, 2019
…-all fix #296171: fix triggerLayoutAll() for spanners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/296171 (a regression from #5422)
Fixup for 99c7b0d
triggerLayout() and triggerLayoutAll() implementations in Element have an optimization that allows to avoid triggering layout for elements not yet added to a score by checking the element's parent. This optimization is not suitable for spanners since they don't have a parent even when added to a score. This commit adds a missing implementation of Spanner::triggerLayoutAll() that takes this into account.