Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #23538: update accidentals when tie is deleted #545

Merged

Conversation

heuchi
Copy link
Contributor

@heuchi heuchi commented Nov 14, 2013

UPDATED: This is to fix #23538 (formerly #12116):

Added call to updateAccidentals() in Chord::remove(Element_) and Note::remove(Element_) to make sure, notes which are no longer tied back get needed accidentals. This was the described issue #23538.

Let RemoveElement::undo() reset the tieBack property of the tie's endNote when restoring a removed tie, to avoid crashes.

Added a call to updateAccidentals() for the end measure of a tie being removed in RemoveElement::redo():
Example: Key signature of F major, a B nat is tied to the next measure which contains a second B nat.
This second B nat needs an accidental because the tied note doesn't have one. If the tie is removed, the first note gets a natural and now the second one does no longer need one. Therefore we need to check the measure of the last note of the tie.

wschweer added a commit that referenced this pull request Nov 18, 2013
Fix #23538: update accidentals when tie is deleted
@wschweer wschweer merged commit ff6d8ff into musescore:master Nov 18, 2013
@heuchi heuchi deleted the 23538_delete_tie_update_accidentals branch November 18, 2013 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants