fix #296426: fix not linking multiple elements at the same tick in MM rests on score loading #5451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rests on score loading The issue has two parts: 1) If a linked element belongs not to the first MM rest measure (e.g. a BarLine), <linked> and <linkedMain> tags may have been written out of a proper order. 2) If several links bind pairs of elements in the same score at the same tick, these linkes may have been not established properly on score loading. Both issues needs to be fixed to fix linking of elements in the case described in the issue (MM rests split by a barline with text elements attached), so both fixes are included to this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/296426
The issue has two parts:
a BarLine),
<linked>and<linkedMain>tags may have been written outof a proper order.
same tick, these linkes may have been not established properly on
score loading.
Both issues needs to be fixed to fix linking of elements in the case
described in the issue (MM rests split by a barline with text elements
attached), so both fixes are included to this commit.