Fix #296610 : import from 2.x may create useless "Fig. bass" user text style #5454
Conversation
|
No idea why AppVeyor fails; the log is hardly comprehensible: if shows a huge amount of errors all over the place having to do with the keyword Anyone knows what is wrong? Could be an AppVeyor problem? |
|
My guess is that It apparently is, windows.h including winbase.h. How about naming it |
|
Thanks @Jojo-Schmitz ! Updated. EDIT: And it worked! |
| TEXT_STYLES | ||
| // special, no-contents, styles used while importing older scores | ||
| TEXT_STYLES, // used for user-defined styles | ||
| IGNORED_STYLES // used for styles no longer relevant (mainly Figured bass text style) |
There was a problem hiding this comment.
Might be for "Repeat Text" too? ISTR your scores using those.
There was a problem hiding this comment.
Possibly. I am not entirely sure yet that the "RepeatText" does not come from some customisation of mines. And this PR and the issue it refers to are already well defined in title, topic, code, etc. So, maybe another PR when I will be sure it is an MS problem and not mine.
There was a problem hiding this comment.
You're probably right, it is is separate issue.
There was a problem hiding this comment.
Hmm, MuseScore 2 had 3 different Repeat text styles (Repeat Text Left, Repeat Text Right and Repeat Text), MuseScore 3 has only 2 (Repeat Text Left, Repeat Text Right), so it is not your fault, other that that you customized that 'excess' Repeat Text.
So ignoring it may indeed be the way to go?
There was a problem hiding this comment.
If there is nowhere to put it, I believe the way is to ignore it. Yes, I customised it, but eventually it was not really usefully, so I totally forgot about it!
Maybe it would be better to drop this PR and push a new one ignoring both?
There was a problem hiding this comment.
I'd just add it to this here "while at it also ignore the no longer existing text style 'Repeat Text'", which as far as I can tell is just one additional line of code.
There was a problem hiding this comment.
Updated with "Repeat Text" too.
…t style. See the [original issue](https://musescore.org/en/node/296610) for details and why this uext style is useless. The fix simply ignores the "Figured bass" text style while importing from 2.x; possibly customised F.b. parameters are in any case loaded form the relevant tags of the main <Style> section. While at it, this PR also ignores the "Repeat Text" style, which was a generic varinat for "Repeat Text Left" and Repeat Text Right" and no longer exists in ver. 3.x.
See the original issue for details and why this text style is superfluous.
The fix simply ignores the "Figured bass" text style while importing from 2.x; possibly customised F.b. parameters are in any case loaded form the relevant tags of the main <Style> section.