fix #229246: staff incorrectly numbered in "Instruments" dialog #5464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harmoniker1
force-pushed
the
instr-dialog-staffno
branch
from
0176d22
to
7ef0fc2
Compare
Harmoniker1
changed the title
Harmoniker1
force-pushed
the
instr-dialog-staffno
branch
from
7ef0fc2
to
3c99bfc
Compare
Harmoniker1
changed the title
Staff numbers are only updated (actually re-created by `genPartList()`) upon next opening of the dialog, not instantly when staffs are changed. A new function `updatePartIdx()` does what's needed to be done.
Harmoniker1
force-pushed
the
instr-dialog-staffno
branch
from
3c99bfc
to
06a09d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/node/229246.
Staff numbers are only updated (actually re-created by
genPartList()) upon next opening of the dialog, not instantly when staffs are changed. A new functionupdatePartIdx()does what's needed to be done.