enhance text tab command to preserve placement

[Harmoniker1]

Resolves: https://musescore.org/en/node/297092#comment-958921.

If current text (staff text/system text/fingering) is UNSTYLED or NOSTYLE, the next text created using text tab command inherits the same PropertyFlags and Placement, making it much easier to put all texts above/below staves.

[MarcSabatella]

This should work for other text types as well, BTW. I call it "fingering mode" but usually put it in quotes, because it actually works for staff text etc. Only difference is you need Alt+Right/Left rather than Space/Shift+Space to do the navigation. So this change should in theory also allow you to flip a staff text below, start editing it, and hit Alt+Right and the new texts are also below.

I haven't built this but I expect it works as expected :-)

[Harmoniker1]

@MarcSabatella I included staff text & system text as well. Thanks for clarifying! I didn't even know they can do the same. I'm just not sure if I called it right, text-tab mode? Is there a more conventional name for that?

[MarcSabatella]

Since the original impetus was for fingerings and only during implementation did I see that it could work just as easily for other text, “fingering mode” is still the most recognized name. But it’s not just for fingering and it’s not a separate mode at all. So, “text tab command” is probably accurate.

[Harmoniker1]

Done, thanks!

[Harmoniker1]

I'm interested in script test. I'll see if I can create one for this.

But I see in that introduction forum topic, "Text edit is not recorded", so I'm not sure whether a script test can be created for this...

[Harmoniker1]

Well, text edit isn't recorded, but adding texts is.

[Harmoniker1]

I don't understand, why did Travis build break off?

[Jojo-Schmitz]

The build just took too long, for some reason. Most likely not your fault and restarting that Travis now would most probably pass

[Harmoniker1]

The build just took too long, for some reason. Most likely not your fault and restarting that Travis jow would most probably pass

I did it twice but got the same error, and the build stopped exactly when the scripts were build. Doesn't look like a coincidence.

[Jojo-Schmitz]

Hmm, then that script might be the issue

[Harmoniker1]

Hmm, then that script might be the issue

But what kind of issue exactly can block a build?! Infinite loop? There isn't any.
Travis suggests that the error could be due to build configuration. Then it's not my problem ;-)

[dmitrio95]

You can try reproducing this error by running this script test from a command line:

mscore --run-test-script text_tab_preserve_placement.script

However text editing is indeed currently not recorded by the script recorder engine, and cmd staff-text adds an empty text which requires editing to contain anything useful, so what you are trying to reproduce with this test is most likely not currently supported by this facility.

[Harmoniker1]

Deleted the tests.

[dmitrio95]

making it much easier to put all texts above/below staves

Using style settings seems to be a semantically correct way to put all texts above/below staves and it gives a lot of benefits for further score editing. Would it perhaps make sense to limit this enhancement only to fingerings, or maybe make it possible to define an extra fingering style (which would create compatibility issues though)? As far as I understand this change would make it easier to accidentally create large numbers of text elements that do not follow style settings which I would try to avoid if possible.

[Harmoniker1]

As far as I understand this change would make it easier to accidentally create large numbers of text elements that do not follow style settings which I would try to avoid if possible.

As far as I understand, this PR only deals with text tab command, and it's basically not possible to have this kind of "accidents" given that you're already using text tab command. If you insert a unstyled text and then use text tab command, you most probably do want to make all subsequent texts have the same placement.