fix #297326: Crash on opening Musescore 2.x file that uses leading space setting on the initial clef #5481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace setting on the initial clef which seems to not belong to any segment, so dereferences a NULL pointer leading to a segment violation (pun intended). The fix simply ignores this, and this avoids the crash, but also looses the 'visible' property of that clef for some yet unknown but unrelated reason.
Jojo-Schmitz
force-pushed
the
segment-violation
branch
from
f7d9401
to
d9abdeb
Compare
Jojo-Schmitz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which seems to not belong to any segment, so dereferences a NULL pointer leading to a segment violation (pun intended).
The fix simply ignores this, and this avoids the crash, but also looses the 'visible' property of that clef for some yet unknown but unrelated reason.
Solves https://musescore.org/en/node/297310 / https://musescore.org/en/node/297326