fix #281957, fix #297425: Display of beam properties and Dragging multiple selected elements #5494
Conversation
Do not deactivate the highlighted beam mode palette cell when the user clicks on the canvas to drag the score. Also, highlight the beam mode for multiple selected ChordRests, if they all have the same beam mode.
Do not deselect other elements upon mouse press if the element under the mouse is selected. This allows for easier dragging of multiple selected elements. The current behavior of deselecting other elements is retained if a drag is not initiated.
|
This PR reveals a bit unexpected behavior of dragging multiple elements in range selection: if I select a range and try dragging a note in it, not only notes get repitched but also rests, texts and any other selected elements get repositioned. Would it perhaps make more sense to limit dragging to the same element type in range selection (for example, like in this commit) or disabling dragging for range selection at all? This behavior was there before this PR as well, but it was nearly undiscoverable as one had to hold Shift and start dragging to see the same result. |
|
I like the solution in your linked commit, because it allows the user to do what he or she is trying to do, and it does not try to second-guess the user's intent. It would be a shame to preserve the selection but then turn around and disable the drag, which was the alternative that you gave. |
This PR addresses two issues that are mostly unrelated, but they both involve the
clickOffElementvariable which I have renamed tomodifySelection.First issue: https://musescore.org/en/node/281957#comment-961204
Second issue: https://musescore.org/en/node/297425