Replace MuseScore with Musescore (+ collect_artifacts) #5519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the packages titles and build docs
anatoly-os
force-pushed
the
MuseScore_to_Musescore
branch
from
0d85109
to
a525419
Compare
Harmoniker1
reviewed
Dec 6, 2019
| @@ -279,7 +279,7 @@ set(CMAKE_BUILD_WITH_INSTALL_RPATH ON) # Call CMake with option -DCMAKE_SKIP_RPA | |||
| set(CMAKE_SKIP_RULE_DEPENDENCY TRUE) | |||
|
|
|||
| # The MuseScore version number. | |||
There was a problem hiding this comment.
This should be changed too?
| @@ -126,7 +126,7 @@ fetch-package-dependencies() { | |||
| # BUILD MuseScore PORTABLE (Compile, not package) | |||
There was a problem hiding this comment.
This should be changed too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the packages titles and build docs
MuseScore was decided to be renamed to Musescore everywhere for marketing purposes. Most of the renaming process has been done on other resources, but the software is the most complex one. Let's start with visible packages names.
Next step is to replace MuseScore with Musescore in all visible strings.