[Inspector] fix #298272, fix #298363: inspector title issues #5522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
reviewed
Dec 9, 2019
Harmoniker1
force-pushed
the
ornament-inspector
branch
4 times, most recently
from
a9d82c6
to
b3d369a
Compare
Harmoniker1
changed the title
Harmoniker1
force-pushed
the
ornament-inspector
branch
3 times, most recently
from
61236ab
to
88227c3
Compare
Harmoniker1
changed the title
Harmoniker1
changed the title
dmitrio95
reviewed
Dec 25, 2019
…subtype doesn't update inspector title Resolves: https://musescore.org/node/298363. From 2.x to 3.x, a change was made which leaded to the issue: if `oSameTypes != sameTypes`, inspectors will not be updated. Even if slur and tie/breath and caesura/articulation and ornament are both selected, for each group `sameType` will continue to give `true`, and so the inspector is not updated. This patch adds another field: `sameSubtypes`. If `sameTypes` is `true` but the subtypes are different, the inspector will be updated too.
Harmoniker1
force-pushed
the
ornament-inspector
branch
from
88227c3
to
344c022
Compare
anatoly-os
added a commit
that referenced
this pull request
Jan 15, 2020
[Inspector] fix #298272, fix #298363: inspector title issues
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jan 15, 2020
Fixes a MinGW warning and logical flaw.
anatoly-os
pushed a commit
that referenced
this pull request
Jan 17, 2020
Follow up fix for PR #5522
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/node/298272.
&&
Resolves: https://musescore.org/node/298363.
From 2.x to 3.x, a change was made which leaded to the issue: if
oSameTypes != sameTypes, inspectors will not be updated. Even if slur and tie/breath and caesura/articulation and ornament are both selected, for each groupsameTypewill continue to givetrue, and so the inspector is not updated.This patch adds another field:
sameSubtypes. IfsameTypesistruebut the subtypes are different, the inspector will be updated too.